Convert cross-compile tests to Go - #3575
Open
peterebden wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are kind of annoying - they require a gcc multilib setup, which I guess I used to have, but currently don't, so
plz test //test/...keeps hitting them and failing. (You can of course fix that with--excludeas bootstrap does, but I never think of it).Just use Go instead, we know we have it and it can cross-compile out of the box. Some minor changes since it can't target
linux_x86- which doesn't specifically matter, but it means the produced binary isn't runnable as the old one used to be, so we have to check its architecture (which I'm also doing in go to avoid needing extra things likefile).