Move cyclic_dependency_test to a plz_repo_e2e_test

test/BUILD

@@ -307,16 +307,6 @@ plz_e2e_test(
     expected_output = "query_alltargets_2.txt",
 )
 
-plz_e2e_test(
-    name = "cyclic_dependency_test",
-    timeout = 30,
-    cmd = "plz test //plz-out/tmp/test/cyclic_dependency_test._test/run_1/test/cycle:all",
-    data = ["cycle/TEST_BUILD"],
-    expect_output_contains = "Dependency cycle found",
-    expected_failure = True,
-    pre_cmd = "mv test/cycle/TEST_BUILD test/cycle/BUILD",
-)
-
 # Used manually for testing the test flakiness stuff.
 python_test(
     name = "flaky_test",

test/cyclic_dependency/BUILD

@@ -0,0 +1,11 @@
+subinclude("//test/build_defs")
+
+please_repo_e2e_test(
+    name = "cyclic_dependency_test",
+    expected_failure = True,
+    expect_output_contains = {
+        "output.txt": "Dependency cycle found",
+    },
+    plz_command = "plz test //cycle:all > output.txt 2>&1",
+    repo = "test_repo",
+)

test/cyclic_dependency/test_repo/.plzconfig

@@ -0,0 +1,3 @@
+[Parse]
+BuildFileName = BUILD_FILE
+

test/cycle/TEST_BUILD → test/cyclic_dependency/test_repo/cycle/BUILD_FILE

@@ -1,12 +1,12 @@
 # A set of build targets that test issue #43.
 # Due to the nature of how we exercise the issue the test itself cannot be in this package.
 
-python_library(
+filegroup(
     name = "cycle_1",
     deps = [":cycle_2"],
 )
 
-python_library(
+filegroup(
     name = "cycle_2",
     deps = [":cycle_1"],
 )