chore: retire the local pr-review skill now that Pullfrog reviews every PR - #473
Merged
Merged
Conversation
…ry PR Paired with the orbit-ui-mobile change that makes Pullfrog the only reviewer. `.claude/skills/pr-review/SKILL.md` was a 26 line pointer to the orbit-ui-mobile skill that is being deleted, so it becomes a dangling reference. It goes. `CLAUDE.md` carried a claim that is now false: "No review status check exists in either repository". One does. `pullfrog-approval` is a required status check on `main` in both code repositories, pinned to app id 1768019, verified live. `required_approving_review_count` is still 0, so that half of the sentence stands and is kept. `contract-aligner` and `security-reviewer` auto-invoked "during /pr-review", a trigger that stops existing. Pullfrog runs as a service in GitHub Actions and cannot invoke a local Claude Code agent, so no automatic trigger would be honest. Both become manual only, and stay available as lenses to `/audit-code-quality` and `/audit-security`. `.opencode/agents/contract-aligner.md` carries the identical change, because the two are declared lockstep copies. `second-opinion` claimed `/pr-review` had a "Phase 6" that auto-fired it. That claim was already false before this change: `/pr-review` had no Phase 6 and never named second-opinion. It now says plainly that nothing fires it automatically. `.gitattributes` and `tools/check-frontmatter.mjs` lose comment text that described the pr-review mirroring contract and a vendored upstream that no longer exists. The rules themselves are unchanged. `.github/workflows/pullfrog.yml` loses 3 em dashes from its comments, which the Dash Ban gate rejects. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the local review-skill retirement, surviving agent metadata, repository guidance, and hygiene comments.
- Reviewer retirement: Deletes the now-dangling API pointer while paired orbit-ui-mobile PR #716 removes the canonical local reviewer and rewires readiness around Pullfrog.
- Manual specialist tools: Updates
contract-aligner,security-reviewer, andsecond-opiniondescriptions to match their surviving invocation paths. - Repository guidance: Records Pullfrog as the sole PR reviewer and the required
pullfrog-approvalcontext while retaining the zero-approval-count rule. - Hygiene cleanup: Removes stale mirroring prose and dash-ban-incompatible workflow comments without changing gate behavior.
GPT Sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What this does
Paired with thomasluizon/orbit-ui-mobile#716, which makes Pullfrog the only pull request reviewer and deletes the local review machinery. This is the api half.
Order does not matter here. Neither PR changes a DTO, so the deploy-API-first rule does not apply.
Changes
Deleted
.claude/skills/pr-review/SKILL.md. It was a 26 line pointer to the orbit-ui-mobile skill that #716 deletes, so it becomes a dangling reference.Corrected a false claim in
CLAUDE.md. It said "No review status check exists in either repository". One does now:pullfrog-approval, a required status check onmainin both code repositories, pinned to app id1768019. Verified live withgh api repos/thomasluizon/orbit-api/branches/main/protection.required_approving_review_countis still0, so that half of the sentence stands and is kept.contract-alignerandsecurity-reviewerbecome manual only. Both auto-invoked "during/pr-review", a trigger that stops existing. Pullfrog runs as a service in GitHub Actions and cannot invoke a local Claude Code agent, so no automatic trigger would be honest. They stay available as lenses to/audit-code-qualityand/audit-security..opencode/agents/contract-aligner.mdcarries the identical edit, because the two are declared lockstep copies.second-opinionloses a claim that was already false. It said/pr-reviewhad a "Phase 6" that auto-fired it on each surviving Critical or High finding./pr-reviewhad no Phase 6 and never named second-opinion, so the claim was wrong before this change too. It now says plainly that nothing fires it automatically.Comment cleanup in
.gitattributesandtools/check-frontmatter.mjs. Both described the pr-review mirroring contract, andcheck-frontmatter.mjsalso claimed to be vendored from an orbit-ui-mobile file that does not exist. The rules themselves are unchanged; only the prose that had gone false..github/workflows/pullfrog.ymlloses 3 em dashes from its comments, which the Dash Ban gate rejects.Verification
node tools/check-frontmatter.mjsfrontmatter ok: 5 skill and agent files parsenode tools/check-dashes.mjs --check-baselinenode tools/check-root-allowlist.mjsgrep -rn "pr-review"over the whole repository returns nothing. So does the same sweep forchatgpt-codex-connectorandcodex-only.🤖 Generated with Claude Code