refactor(storage): gaxios migration system test fix

handwritten/storage/src/file.ts

@@ -1752,6 +1752,7 @@ class File extends ServiceObject<File, FileMetadata> {
         queryParameters: query as unknown as StorageQueryParameters,
         responseType: 'stream',
         decompress: options.decompress,
+        compress: false,
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
       } as any;
 

handwritten/storage/src/storage-transport.ts

@@ -183,6 +183,20 @@ export class StorageTransport {
       hasEtagInBody
     );
 
+    // Helper to enrich GaxiosError objects with legacy ApiError properties
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    const decorateError = (err: any) => {
+      if (err && typeof err === 'object') {
+        err.code = err.response?.status || err.status || err.code;
+        if (err.response?.data?.error) {
+          const apiError = err.response.data.error;
+          if (apiError.message) err.message = apiError.message;
+          if (apiError.errors) err.errors = apiError.errors;
+        }
+      }
+      return err;
+    };
+
     try {
       const requestPromise = this.authClient.request<T>({
         adapter: async (opts: GaxiosOptions) => {
@@ -236,20 +250,25 @@ export class StorageTransport {
         return data;
       };
 
+      const enrichedPromise = requestPromise.catch(err => {
+        throw decorateError(err);
+      });
+
       if (callback) {
-        requestPromise
+        enrichedPromise
           .then(resp => callback(null, decorateMetadata(resp), resp))
           .catch(err => callback(err, null, err.response));
-        return requestPromise;
+        return enrichedPromise;
       }
 
-      return requestPromise;
+      return enrichedPromise;
     } catch (e) {
+      const err = decorateError(e);
       if (callback) {
-        callback(e as GaxiosError);
-        return Promise.reject(e);
+        callback(err as GaxiosError);
+        return Promise.reject(err);
       }
-      throw e;
+      throw err;
     }
   }
 

handwritten/storage/system-test/fixtures/index-cjs.js

@@ -12,11 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// eslint-disable-next-line no-undef
+/* eslint-disable node/no-missing-require, no-unused-vars, no-undef */
 const {Storage} = require('@google-cloud/storage');
 
 function main() {
-  // eslint-disable-next-line no-unused-vars
   const storage = new Storage();
 }
 

handwritten/storage/system-test/fixtures/index-esm.js

@@ -12,11 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// eslint-disable-next-line no-undef
-const {Storage} = require('@google-cloud/storage');
+/* eslint-disable node/no-missing-import, no-unused-vars */
+import {Storage} from '@google-cloud/storage';
 
 function main() {
-  // eslint-disable-next-line no-unused-vars
   const storage = new Storage();
 }
 

handwritten/storage/system-test/kitchen.ts

@@ -55,7 +55,10 @@ describe('resumable-upload', () => {
     retryableErrorFn: RETRYABLE_ERR_FN_DEFAULT,
   };
 
-  const bucket = new Storage({retryOptions}).bucket(bucketName);
+  const bucket = new Storage({
+    projectId: process.env.PROJECT_ID,
+    retryOptions: retryOptions,
+  }).bucket(bucketName);
   let filePath: string;
 
   before(async () => {
@@ -97,7 +100,7 @@ describe('resumable-upload', () => {
     // see: https://cloud.google.com/storage/docs/exponential-backoff:
     const ms = Math.pow(2, retries) * 1000 + Math.random() * 2000;
     console.info(`retrying "${title}" in ${ms}ms`);
-    setTimeout(done(), ms);
+    setTimeout(() => { done(); }, ms);
   }
 
   it('should work', done => {