docs(storage): add comprehensive JSDoc documentation to GetSignedUrlConfig interface properties#27
docs(storage): add comprehensive JSDoc documentation to GetSignedUrlConfig interface properties#27thiyaguk09 wants to merge 7 commits into
Conversation
…onfig interface properties
There was a problem hiding this comment.
Code Review
This pull request reorganizes the properties of the GetSignedUrlConfig interface in handwritten/storage/src/file.ts and adds comprehensive JSDoc documentation to each field to improve code readability and developer experience. No review comments were provided, and there is no additional feedback.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| export interface GetSignedUrlConfig | ||
| extends Pick<SignerGetSignedUrlConfig, 'host' | 'signingEndpoint'> { | ||
| /** |
There was a problem hiding this comment.
did you follow any existing doc?
There was a problem hiding this comment.
not exactly followed, but referred this doc https://googleapis.dev/nodejs/storage/latest/File.html#getSignedUrl
There was a problem hiding this comment.
now update based on this doc https://googleapis.dev/nodejs/storage/latest/File.html#getSignedUrl. PTAL.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕