Skip to content

feat(storage): support copying CSEK-encrypted files to non-CSEK destinations#26

Open
thiyaguk09 wants to merge 9 commits into
mainfrom
feat/7351-copy-csek-to-unencrypted
Open

feat(storage): support copying CSEK-encrypted files to non-CSEK destinations#26
thiyaguk09 wants to merge 9 commits into
mainfrom
feat/7351-copy-csek-to-unencrypted

Conversation

@thiyaguk09

Copy link
Copy Markdown
Owner

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…SEK and fix copy behavior for non-encrypted destinations

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for null encryption keys to allow copying CSEK-encrypted files to standard non-CSEK destinations. The review identifies a critical bug in the copy logic where the source file's encryption key is mutated and the destination file is left in an inconsistent state by bypassing setEncryptionKey. Feedback also suggests correcting the corresponding unit tests to avoid asserting on this buggy behavior and to use the proper setter method instead of manually assigning dummy properties.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread handwritten/storage/src/file.ts Outdated
Comment thread handwritten/storage/test/file.ts Outdated
Comment thread handwritten/storage/test/file.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants