Skip to content

Fix landing admin option typing and theme demo title - #113

Merged
thinkdj merged 2 commits into
claude/add-theme-system-IVo71from
copilot/sub-pr-112
Feb 19, 2026
Merged

Fix landing admin option typing and theme demo title#113
thinkdj merged 2 commits into
claude/add-theme-system-IVo71from
copilot/sub-pr-112

Conversation

Copilot AI commented Feb 19, 2026

Copy link
Copy Markdown

The Next.js landing app type-check failed: the theme demo referenced a non-existent themeBase, and landing admin select options lacked required fields for ModelFields.

  • Theme demo title: Use the resolved theme’s name in /theme-demo to avoid undefined config access.
  • Admin select options: Add id/name to section select option objects so landing section forms satisfy ModelFields typing.

Example:

// Theme demo header
<h1 className="font-heading text-4xl font-bold text-foreground">
  Theme Demo: {config.theme.name}
</h1>

// Select options now include id/name
options: SECTION_TYPES.map((t) => ({ id: t, name: t, label: t, value: t }));

https://github.com/user-attachments/assets/ff28d4fc-08a5-47d9-aa03-e5364a50e9ef


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: thinkdj <688055+thinkdj@users.noreply.github.com>

Copilot AI commented Feb 19, 2026

Copy link
Copy Markdown
Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • sparrow.cloudflare.com
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --no-warnings --experimental-vm-modules /home/REDACTED/work/ottabase/ottabase/node_modules/.pnpm/wrangler@4.63.0_@cloudflare&#43;workers-types@4.20251225.0/node_modules/wrangler/wrangler-dist/cli.js dev -- --port 3004 js,esm --dts --cnode (dns block)
  • workers.cloudflare.com
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node /home/REDACTED/work/ottabase/ottabase/node_modules/.pnpm/next@16.1.1_@babel&#43;core@7.28.6_@opentelemetry&#43;api@1.9.0_react-dom@19.2.4_react@19.2.4__react@19.2.4/node_modules/next/dist/server/lib/start-server.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Refactor homepage and theme preview functionality Fix landing admin option typing and theme demo title Feb 19, 2026
Copilot AI requested a review from thinkdj February 19, 2026 19:52
@thinkdj
thinkdj marked this pull request as ready for review February 19, 2026 20:32
Copilot AI review requested due to automatic review settings February 19, 2026 20:32
@thinkdj
thinkdj merged commit b1e1580 into claude/add-theme-system-IVo71 Feb 19, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes TypeScript type-checking errors in the Next.js landing app by correcting select option typing in OttaORM models and fixing a theme demo page reference.

Changes:

  • Added required id and name fields to select options in landing section form configurations to satisfy ModelFields typing requirements
  • Fixed theme demo page to reference config.theme.name instead of non-existent config.themeBase
  • Updated Next.js 16 auto-generated type import path in next-env.d.ts

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/ottalanding/src/section-fields.ts Added id and name fields to select options for features columns, pricing billing, and feature highlight image position
packages/ottalanding/src/ottaorm-models/LandingSection.ts Added id and name fields to section type select options
apps/ottabase-template-app-nextjs-homepage/app/theme-demo/page.tsx Changed title from config.themeBase to config.theme.name to reference correct property
apps/ottabase-template-app-nextjs-homepage/next-env.d.ts Updated Next.js 16 auto-generated type import path from .next/types to .next/dev/types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants