Repository navigation
docs: pin install instructions and the primer envs to v0.1.5 - #88
Merged
Merged
Conversation
|
Notebooks changed:
Review visual diffs and comment on any notebook cell. All comments sync back to this PR. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 32 32
Lines 4357 4357
=======================================
Hits 4044 4044
Misses 313 313 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Moves every client pin to v0.1.5, which ships #84. With v0.1.4, viewer links go through lamin.ai/storage, which is served from aws.us-east-1 (#81). #84 serves the S3 proxy from the eu-central-1 LaminHub host and encodes the slash after the bucket.
Changes:
ALPHA_TAGin tests/test_docs_quickstart.py moves with them.docs/primers/atera/pixi.toml) moves from v0.1.4 to v0.1.5. The primer pipeline env (primers/env/pixi.toml) moves from v0.1.3 to v0.1.5, because it was still on a release with the us-east-1 links.pixi.lockfiles are edited by hand, and only in the spatialdata-db entry: the tag, the commit c9a71d3, the version 0.1.5, and the newloaderextra inrequires_dist. I didn't re-solve them, because re-solving needs the CUDA conda env installed, and pixi 0.84 would rewrite both locks to the v7 format. To do: whoever next runs a primer env on a GPU node should runpixi install --lockedto confirm.docs/primers/atera/primer.ipynbstill says "sddb 0.1.4", because that's what the notebook ran with. I left it as is.Besides #84, v0.1.5 also ships #85, which changes behaviour:
to_anndataandmaterializenow keep only in-tissue rows by default. It also ships #86, #75, #77 and #80.