fix(macos): restore share blocks and handle Mac-compressed ZIPs - #43
Merged
Merged
Conversation
theincrediblewwz
marked this pull request as ready for review
September 8, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Mac share import could lose Windows block boundaries and fail on folders compressed by macOS when UTF-8 filenames lacked the ZIP language flag. Import now restores top-level exported block IDs, source types, order and separate Markdown files; Mac ZIP export retains that metadata. Legacy unmarked Markdown remains one block, and merged continuation groups without internal offsets remain intact with a notice.
The native picker now opens asynchronously after Notebooks dismissal, attaches to the initiating workspace through a stable window anchor, and filters folders/ZIP/Markdown without mixed inferred UTIs. Main-window ZIP/folder drops also use the share importer. ZIP filename decoding honors Unicode path metadata, accepts strictly valid UTF-8 without bit 11, and retains legacy CP437 fallback plus all existing path/size/CRC checks.
Validation
User acceptance and release
On 2026-09-08 the user confirmed foreground file selection and import now work, and requested the ZIP plus GitHub release update. Automated keyboard-based fixture checks and this human mouse acceptance are recorded separately. README and release documentation now identify macOS 0.3.7. Publish through the normal Mac release workflow after merging; Windows/Android release assets remain unchanged.