Skip to content

README examples do not work; Need more complete test cases #17

Description

@utdrmac

The 3rd code example in the README shows serializer_class=JsonHandler which does not exist, and thus the example fails.

If you change the PersistentDirectoryClient example (just above Contribute) to use PickleSerializer, the example fails.

Looking at tests/sequences/test_iterables.py, all of the tests for FileList, and FileDeque use the default client class, TemporaryDirectoryClient, and default serializer PickleZLibSerializer. None of the tests use PersistentDirectoryClient, which would have revealed the issues in #16. None of the tests use PickleSerializer, nor the Json serializers.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions