Fix Fedora support in setup playbook - #433
Open
ogajduse wants to merge 3 commits into
Open
Conversation
ansible_os_family returns 'RedHat' on Fedora, not 'Fedora'. Use ansible_distribution instead, which correctly returns 'Fedora'. This caused Fedora-specific packages (e.g. quvi) to never be installed when running `obal setup` on Fedora. Fixes theforeman#431
git-annex-standalone is not available in Fedora repos. The existing condition only distinguished between EL7 and EL8+, but Fedora also needs plain git-annex like EL7. Add ansible_distribution == 'Fedora' check so Fedora systems get git-annex instead of the non-existent git-annex-standalone. Fixes theforeman#432
Member
Author
Test resultsTested
* EL10 fails on Notes
|
The quvi package has been retired from Fedora and is no longer available. It was originally added as a bundled dependency in 2017 but was never actually used by obal code. Since quvi was the only Fedora-specific package, the entire Fedora packages task block is removed. Fixes theforeman#434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ansible_distributioninstead ofansible_os_family(which returnsRedHaton Fedora, notFedora)git-annexinstead ofgit-annex-standaloneon Fedora, sincegit-annex-standaloneis not available in Fedora reposquvipackage and the entire Fedora-specific task block (quvi was the only package there and has been retired from Fedora)Test plan
obal setupon Fedora — verify no errors about missing packagesobal setupon Fedora — verifygit-annexis installed (notgit-annex-standalone)obal setupon EL8 — verifygit-annex-standaloneis installedobal setupon EL9 — verifygit-annex-standaloneis installedobal setupon EL10 — verifygit-annex-standaloneis installedFixes #431, Fixes #432, Fixes #434