fix: use performance.now() instead of Date.getTime() for timing - #156
Open
pedrocruz-seon wants to merge 1 commit into
Open
fix: use performance.now() instead of Date.getTime() for timing#156pedrocruz-seon wants to merge 1 commit into
pedrocruz-seon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculateTime()usedDate.getTime(), which test frameworks, fake timers, and some APM tools commonly patch. A constant override collapses every measurement to 0, so the=== 0guard indetect()bails out every tick and the detector is silently disabled.Fix
Prefer
performance.now()(with aDate.getTime()fallback). It uses the browser's monotonic clock, is harder to stub into a stable constant, and avoids the 1ms floor that made those=== 0guards necessary.