fix: performance detector broken by third-party console overrides - #155
Open
pedrocruz-seon wants to merge 1 commit into
Open
fix: performance detector broken by third-party console overrides#155pedrocruz-seon wants to merge 1 commit into
pedrocruz-seon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The performance detector's baseline used a cached
console.logcaptured at init. When SDKs like Sentry wrapconsole.logbefore that, every baseline tick includes their breadcrumb/serialization overhead, somaxPrintTimeinflates and thetablePrintTime > maxPrintTime * 10check never fires—even with DevTools open.Fix
Measure the baseline with
JSON.stringifyon the same large object array instead ofconsole.log, so the baseline stays independent of console wrappers and DevTools rendering.