Skip to content

Fix Shellcheck SC2021 - #3138

Merged
drwetter merged 1 commit into
testssl:3.3devfrom
dcooper16:fix_SC2021
Sep 14, 2026
Merged

drwetter merged 1 commit into
testssl:3.3devfrom
dcooper16:fix_SC2021

Conversation

@dcooper16

Copy link
Copy Markdown
Collaborator

This PR fixes Shellcheck issue SC2021 by not enclosing list of characters in [...] for the tr command.

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change: bug fix, feature or improvement that would cause existing output (especially JSON, CSV) to not work as expected before
  • Typo / spelling fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md
  • My code follows Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order of last name) and the change to CHANGELOG.md

AI section

  • I found a bug / an improvement using LLM version: [e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]
  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: [e.g. GitHub CoPilot, JetBrains Junie, VS Code plugin <NAME> etc.]
    • LLMs and versions: [e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]

This commit fixes Shellecheck issue SC2021 by not enclosing list of characters in "[...]' for the 'tr' command.
@drwetter
drwetter merged commit 25fcac5 into testssl:3.3dev Sep 14, 2026
4 checks passed
@drwetter

Copy link
Copy Markdown
Collaborator

Looking forward this seems fine, reading the shellcheck doc . Thx!

@dcooper16
dcooper16 deleted the fix_SC2021 branch September 14, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants