Conversation
Only the protocol section for now #756 (comment)
- hardcode days and protocol as they don't matter - got rid of the ugly system call with nc
The previous commit held the socket open in the perl 1..30 loop which prevented later on testssl.sh to scan. Also the subtets is gone . It removes and addiotional message which was confusing.
... , exec server with log and started testssl differently
- MacOS: LibreSSL doesn't understand -naccept, so we use homebrew's OpenSSL - Ubuntu: No idea why that still fails. Maybe the DNS setup is borked, so that scanning and listening is split between IPv4 and IPv6 (weak guess)
in order to find out why it works on regular Linux machines and not on Github. One guess was different network namespace. However it fails alos on MacOS . Also, as I changed the hostname "localhost" to 127.0.0.1 before, I at least wanted to add the IP address to SAN.
- remove -naccept as it was futile - fix identation - kill the server when run locally (perl's PID was wrong) - quiet key generation This works on both Linux and Mac locally (except some debug stuff unser MacOS)
It doesn't exist on MacOS' LibreSSL and on older OpenSSL. The server started locally because the keys were already present.
drwetter
marked this pull request as draft
September 6, 2026 15:46
... in orser to try preventing s_server to die . Doesn't work locally.
- comment redundant diag line - make sure $openssl_pid has a value
... whether this works as GHA. It does under a Ubuntu 24.04 VM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the protocol section for now and only . For testing it uses whatever is the default on each platform, for Linux x64 still the supplied binary, for MacOS the LibreSSL version from MacOS.
#756 (comment)
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()AI section
[e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]Qwen-3.6,Qwen-3.8