Repository navigation
Prima do/check: pass page knowledge (incl. --auth) to the agent - #305
Merged
Merged
Conversation
pageContext() sent the ARIA tree, UI map and experience but never the knowledge, so --auth, --knowledge and knowledge files never reached the do agent and sign-in steps blocked with "no auth details". Render it with renderRelevantContext(), as Tester, Navigator and Researcher do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
prima doandprima checkignored knowledge.--auth/EXPLORBOT_AUTHand--knowledgewere loaded as session knowledge, butPrima.pageContext()built the agent prompt from the ARIA tree, UI map and experience only. A sign-in step blocked with "no auth details are shown anywhere on the page" even with--authgiven. Knowledge files on disk were dropped the same way.Fix
pageContext()now addsknowledgeTracker.renderRelevantContext(result), the same renderer Tester, Navigator and Researcher use. It goes out with every page context, so it's re-sent after navigation too.Verified
Against a local app with a login form:
ok: false, step 1 blocked with "no auth details"ok: true, filled the key, signed in, landed on/portal/agentsbun test boat/prima/tests(156) andbun test tests/integration/(175) pass.Not in this PR
prima go <path>decides arrival by URL only, so an app that shows a sign-in form at the requested URL (no redirect) returnsok: truewithout logging in.🤖 Generated with Claude Code