Repository navigation
Firefox example: connect over WebDriver BiDi (TB-1003) - #2
Merged
Merged
Conversation
Firefox removed CDP in 129, so puppeteer.connect needs protocol: 'webDriverBiDi' for Firefox. Server side this needs testingbot/ws-hub#26.
There was a problem hiding this comment.
🔵 Needs a closer look
Live correctness remains unverified because the change relies on the separately deployed ws-hub#26 WebDriver BiDi proxy and was validated only through static review and syntax checks.
No open issues 🎉
What changed in this PR
Updates the Firefox Puppeteer example to connect through WebDriver BiDi, which is required for current Firefox versions where CDP is unavailable.
Changes:
- Adds
protocol: 'webDriverBiDi'to the Firefoxpuppeteer.connectoptions. - Documents the Firefox protocol requirement.
- Retains the existing TestingBot endpoint and capabilities; syntax verification passed with
node --check.
| File | Description |
|---|---|
| examples/puppeteer/firefox/test.js | Configures the Firefox Puppeteer example to connect through WebDriver BiDi while preserving the existing TestingBot session configuration. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run test:puppeteer:firefoxfails on TestingBot today (TB-1003, https://testingbot-team.atlassian.net/browse/TB-1003). Firefox removed CDP in Firefox 129, so Puppeteer must connect to it withprotocol: 'webDriverBiDi'. This adds that toexamples/puppeteer/firefox/test.js.The server side is testingbot/ws-hub#26. It makes
/puppeteerproxy Firefox sessions to the browser's WebDriver BiDi socket. This example passes only once that is deployed. Before then it fails with or without this change. The repro sessions with puppeteer-core 25.16.0 and Firefox 158 are in the ws-hub PR.Verified:
node --check. The same connect options (puppeteer-core 25.16.0,protocol: 'webDriverBiDi') passed live against a TestingBot Firefox 158 session through a relay that does ws-hub#26'ssession.newrewrite (session5d8a2194476b-ffd54c647799-28ae51193702-179430413696-44615201). This file itself was not run end to end, because that needs the deploy.Independent of #1 (Jest/WebdriverIO fixes).