Repository navigation
feat(ios): delegate clearState / clearKeychain on real devices to a host hook - #3
Merged
Merged
Conversation
…ost hook Physical iPhones cannot wipe an app's container or keychain in place, so clearState was a logged no-op that still reported COMPLETED. When MAESTRO_IOS_DEVICE_RESET_HOOK points at an executable, DeviceControlIOSDevice runs '<hook> clear-state <bundleId>' and '<hook> clear-keychain' and fails the command on a non-zero exit. Without the hook the old behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical iPhones cannot wipe an app's container or keychain in place, so clearState was a logged no-op that still reported COMPLETED. When
MAESTRO_IOS_DEVICE_RESET_HOOKpoints at an executable,DeviceControlIOSDeviceruns<hook> clear-state <bundleId>/<hook> clear-keychainand fails the command on a non-zero exit. Without the hook, behaviour is unchanged. The vm driver provides the hook (testingbot/vm feature-mobile).Tests:
./gradlew :maestro-ios:test --tests 'ios.devicectl.*'(7 passing).