feat(terraphim_grep): failover to fff-search enhanced grep when KG is not configured#4
Closed
AlexMikhalev wants to merge 2 commits into
Closed
feat(terraphim_grep): failover to fff-search enhanced grep when KG is not configured#4AlexMikhalev wants to merge 2 commits into
AlexMikhalev wants to merge 2 commits into
Conversation
… not configured - Make code-search a default feature so fff-search is always available. - Add resolve_thesaurus() helper that returns an empty Thesaurus when no project thesaurus is found instead of failing the CLI. - Log an info message when running in fff-search-only mode. - Add unit test for empty-thesaurus search and integration test for the CLI invocation without --thesaurus. Refs #55
- Bump workspace.package.version from 1.20.5 to 1.21.0. - Align terraphim_grep's terraphim_service dependency with the current registry patch (1.20.5). Refs #55 Refs #2995
Contributor
Author
SummaryThis PR makes Key changes:
What was done well:
What remains to consider:
Confidence Score: 5/5
Important Files Changed
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[terraphim-grep query] --> B{--thesaurus or default?}
B -->|Yes| C[Load Thesaurus]
B -->|No| D[Empty Thesaurus]
C --> E[HybridSearcher]
D --> E
E --> F{KG search}
F -->|Concepts found| G[Boost chunks with KG]
F -->|No concepts| H[fff-search only]
G --> I[GrepResult]
H --> I
style D fill:#d4edda,stroke:#28a745
style H fill:#d4edda,stroke:#28a745
Inline FindingsNo findings. The implementation matches the design and the integration test provides end-to-end evidence. FooterLast reviewed commit: a15f49e | Reviews (1) |
Contributor
Author
|
Closing in favour of the canonical Gitea PR: https://git.terraphim.cloud/terraphim/terraphim-clients/pulls/56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes terraphim-grep usable without a knowledge-graph thesaurus by falling back to fff-search enhanced grep mode. Also bumps the workspace version to 1.21.0.
Changes
Verification
Related