Skip to content

fix(tests): use portpicker for ephemeral port in default_role_integration_test #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexMikhalev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): use portpicker for ephemeral port in default_role_integration_test #933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions terraphim_server/tests/default_role_integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,9 @@ async fn test_default_role_ripgrep_integration() {
log::info!("✅ Default role configuration validated");
log::info!(" - Ripgrep haystack: {}", ripgrep_haystack.location);

// Start server on a test port
let server_addr = "127.0.0.1:8085".parse().unwrap();
// Start server on an ephemeral port to avoid address-already-in-use conflicts
let port = portpicker::pick_unused_port().expect("No unused ports available");
let server_addr: std::net::SocketAddr = ([127, 0, 0, 1], port).into();
let server_handle = tokio::spawn(async move {
if let Err(e) = axum_server(server_addr, config_state).await {
log::error!("Server error: {:?}", e);
Expand All @@ -129,7 +130,7 @@ async fn test_default_role_ripgrep_integration() {

let client = terraphim_service::http_client::create_default_client()
.expect("Failed to create HTTP client");
let base_url = "http://127.0.0.1:8085";
let base_url = format!("http://127.0.0.1:{}", port);

// Test 1: Health check
log::info!("🔍 Testing server health...");
Expand Down