[metrics]: Configure metrics from config - #148
Open
pseudomuto wants to merge 1 commit into
Open
Conversation
The metrics listen address and Prometheus namespace came from --metrics-addr and --metrics-namespace (or METRICS_ADDR and METRICS_NAMESPACE). Everything else the proxy needs already lives in the YAML config, and the Helm chart passes that config wholesale, so metrics were the one thing an operator could not set the same way as the rest. Add a metrics block to the config and have the metrics module read it. This removes both flags and their respective environment variables. The defaults are unchanged at :9090 and tmprl_proxy, so a deployment that never set them behaves identically.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Vaughan-Temporal
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics listen address and Prometheus namespace came from
--metrics-addrand--metrics-namespace(or$METRICS_ADDRand$METRICS_NAMESPACE). Everything else the proxy needs already lives in the YAML config, and the Helm chart passes that config wholesale, so metrics were the one thing an operator could not set the same way as the rest.Add a metrics block to the config and have the metrics module read it. This removes both flags and their respective environment variables. The defaults are unchanged (
:9090andtmprl_proxy), so a deployment that never set them behaves identically.