Repository navigation
Preserve task cancellation when waits complete concurrently - #2149
Draft
VegetarianOrc wants to merge 3 commits into
Draft
VegetarianOrc wants to merge 3 commits into
VegetarianOrc wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add the internal
PRESERVE_TASK_CANCELLATIONflag (4), off by default. It makesworkflow.wait_conditionrespect task shielding and preserves task cancellation when a condition or a Temporal operation completes concurrently. It also retains a cancellation request if it arrives before the primary task is created. The new flag does not enable batching; histories using the original single-batch flag keep their existing behavior.This incorporates the task-local
wait_conditionapproach from #2124.Why?
The original single-batch flag inferred cancellation from workflow-wide state, which could cancel a shielded wait. In other cases, retrying an await could return a completed result and swallow task cancellation. A separate history-recorded flag lets workers adopt these fixes without changing replay behavior for existing histories.
Checklist
Closes: N/A.
How was this tested:
poe testsuite on Python 3.12.13: 1,892 passed, 10 skipped.Any docs updates needed? No public API docs need updating. A changelog fragment describes the opt-in behavior.