Repository navigation
Apply activation jobs before running workflow tasks - #2148
Draft
VegetarianOrc wants to merge 2 commits into
Draft
VegetarianOrc wants to merge 2 commits into
VegetarianOrc wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add the internal
APPLY_ACTIVATION_JOBS_BEFORE_RUNNING_TASKSflag (3). It applies all jobs in an activation before running workflow tasks, without enabling the cancellation changes bundled intoPROCESS_WORKFLOW_ACTIVATION_JOBS_AS_SINGLE_BATCH(2). The new flag is off by default, and replay continues to use the behavior recorded in history.Why?
Workers need a way to opt into batched job processing without also opting into different cancellation semantics. The original flag keeps its existing behavior for replay compatibility.
Checklist
Closes: N/A.
How was this tested:
poe testsuite on the stack tip (Python 3.12.13): 1,892 passed, 10 skipped.Any docs updates needed? No. This is an internal flag and does not change the default behavior.