-
Notifications
You must be signed in to change notification settings - Fork 243
External Storage Integration: NexusWorker #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,259
−24
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
aa76c5a
feat(extstore): integrate into nexus pipeline.
cconstable 78d99fe
Explicitly pass cancellation tokens to extstore.
cconstable 310b070
add more cancellation threading
cconstable cb2dee2
NexusClientImpl integration
cconstable e9580a3
externalStorage -> externalStorageRunner
cconstable 7727fa0
add nexus e2e tests
cconstable 456b810
fix(extstore): handle extstore errors for inbound nexus tasks. report…
cconstable 4a35cb7
fix(extstore): markSlotUsed before payload retrieval.
cconstable d65e8d4
fix(extstore): handle outbound extstore failures properly. reports ba…
cconstable 7bed2c1
formatting
cconstable b3fd59f
add doc comments + test
cconstable 31cc329
report extstore failures without extstore
cconstable 7f56cc6
refactor(extstore): add new nexus resolved options that only exposes …
cconstable 8909a07
only retry failures once and don't send through external storage. add…
cconstable File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
temporal-sdk/src/main/java/io/temporal/internal/client/NexusClientResolvedOptions.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package io.temporal.internal.client; | ||
|
|
||
| import io.temporal.common.converter.DataConverter; | ||
| import io.temporal.common.interceptors.NexusClientInterceptor; | ||
| import java.util.List; | ||
|
|
||
| /** Resolved runtime settings used by the internal Nexus client implementation. */ | ||
| public final class NexusClientResolvedOptions { | ||
|
|
||
| private final String namespace; | ||
| private final List<NexusClientInterceptor> interceptors; | ||
| private final DataConverter dataConverter; | ||
| private final String identity; | ||
|
|
||
| public NexusClientResolvedOptions( | ||
| String namespace, | ||
| List<NexusClientInterceptor> interceptors, | ||
| DataConverter dataConverter, | ||
| String identity) { | ||
| this.namespace = namespace; | ||
| this.interceptors = interceptors; | ||
| this.dataConverter = dataConverter; | ||
| this.identity = identity; | ||
| } | ||
|
|
||
| public String getNamespace() { | ||
| return namespace; | ||
| } | ||
|
|
||
| public List<NexusClientInterceptor> getInterceptors() { | ||
| return interceptors; | ||
| } | ||
|
|
||
| public DataConverter getDataConverter() { | ||
| return dataConverter; | ||
| } | ||
|
|
||
| public String getIdentity() { | ||
| return identity; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.