Update dev command to handle missing proto and fix macos build errors. - #495
Open
collinvandyck wants to merge 3 commits into
Open
collinvandyck wants to merge 3 commits into
collinvandyck wants to merge 3 commits into
Conversation
Added a check to the dev commands that consume the temporal api protos to ensure that the submodule is initialized.
Changed the default to use linux/amd64 so we can build images on a mac host.
This fixes an issue where the last step of the image build when invoked on MacOS
was:
"operating system is not supported"
THardy98
approved these changes
Sep 17, 2026
collinvandyck
enabled auto-merge (squash)
September 17, 2026 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
While testing out the dev command I ran into an issue b/c the proto submodule was not updated. This failed the kitchen sink step of the docker build. Updated the README and also added some errors to the build image command to detect this.
I also ran into an issue trying to build the images on MacOS + docker desktop. The fix was to qualify the platform flag with
linux/.Why?
Wanted to address some issues I found during testing.
Checklist
Closes N/A
How was this tested:
Running
go run ./cmd/dev build-cli-imageon MacOS.I've updated the README