Exercise Nexus workflow messaging in throughput stress - #466
Merged
Merged
Conversation
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 5, 2026 01:58
d2a6e71 to
a7dd764
Compare
stephanos
marked this pull request as draft
September 5, 2026 02:02
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 7, 2026 15:52
a7dd764 to
f985e19
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 7, 2026 18:08
f985e19 to
40d7acd
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 7, 2026 18:36
40d7acd to
5442be6
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 7, 2026 21:09
5442be6 to
380a104
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 7, 2026 21:24
380a104 to
40978b4
Compare
stephanos
commented
Sep 8, 2026
stephanos
commented
Sep 8, 2026
stephanos
commented
Sep 8, 2026
stephanos
commented
Sep 8, 2026
stephanos
commented
Sep 8, 2026
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 8, 2026 17:56
a40418c to
717ec8f
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 8, 2026 20:49
5479ff4 to
fa40d65
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-throughput
branch
from
September 9, 2026 03:18
43b49cd to
3232d06
Compare
…rgonomics-throughput # Conflicts: # loadgen/generic_executor.go # loadgen/generic_executor_test.go
stephanos
removed this pull request from stack #479
September 9, 2026 04:33
stephanos
changed the base branch from
main
to
fix-generic-executor-completion-order
September 9, 2026 04:37
stephanos
added this pull request to stack #481
September 9, 2026 04:37
stephanos
marked this pull request as ready for review
September 9, 2026 14:16
THardy98
approved these changes
Sep 9, 2026
THardy98
left a comment
THardy98
left a comment
Contributor
There was a problem hiding this comment.
Nice! left a clarifying question
| options.Params.WorkflowInput.InitialActions = t.createActions(run) | ||
| actions := t.createActions(run) | ||
| options.Params.WorkflowInput.InitialActions = actions | ||
| t.onActionsCreated(actions) |
Contributor
There was a problem hiding this comment.
is this only populated on scenario start ?
Collaborator
Author
There was a problem hiding this comment.
It's inside of UpdateWorkflowOptions, which is called for each iteration. The tests only have 1 iteration; but if we had 2, we'd see it being called twice.
onActionsCreated defaults to an empty function; only some of the tests override it.
Base automatically changed from
fix-generic-executor-completion-order
to
main
September 9, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in
throughput_stressactions for Nexus signal, signal-with-start, and update.