secondary nav bar poc - #5273
Draft
jsundai wants to merge 4 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview linksThis PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
very much a poc + working draft. only showing a few sections as a poc. underlined vs segmented with gradient. contextually changing second nav bar. dev guides also have a contextual nav.
Notes to reviewers
Changes
sidebars.js: an appended block lifts the four category objects into theirown sidebar exports. The existing 2,211 lines are untouched, so the split can
be reverted by deleting the block.
src/components/SecondaryNav/: the tab bar, plus the URL matching thatdecides which tab is active.
src/theme/Navbar/index.js: renders the bar under the existing navbar. Theprimary navbar is unchanged.
src/css/custom.css:--ifm-navbar-heightnow covers both header rows.Docusaurus sizes the doc sidebar, its sticky offsets, and anchor scroll
positions from that variable, so without this the sidebar container's negative
top margin pulls it up into the bar and its right border runs through the tabs.
.navbarkeeps its own 3.75rem height.