[cherry-pick: release-v0.37.x] fix: add execute-bit check in FindPlugin - #3239
Merged
tekton-robot merged 1 commit intoSep 10, 2026
Merged
Conversation
included execute-bit check in Plugin discovery to only allow executable files. Added tests to verify this execute-bit check. Signed-off-by: Arvind <arvkrish@redhat.com> Assisted-by: Cursor Grok 4.6
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
divyansh42
approved these changes
Sep 10, 2026
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyansh42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #3203
Changes
Included
execute-bitcheck inFindPluginto only allow executable files. Earlier,FindPluginusesos.Statto check file existence in the plugin directory but did not verify the execute bit (Mode()&0o111). A non-executable file matchingtkn-<name>was being returned as a valid plugin path.Added tests to verify this execute-bit check in FindPlugin.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes