fix(brew): install shell completions during brew install - #1
Merged
Conversation
brew install wvm placed only the binary; no bash/zsh/fish completions were emitted because the formula never called the standard Homebrew helper. Add generate_completions_from_executable so a fresh install gets completions in the right per-shell locations. Also chmod 0755 the binary before running it — GitHub's release download strips the exec bit, and bin.install preserves that, so the helper's first call to `wvm completions bash` would EACCES otherwise. Same fix as tegmentum/wsvm@eefe4b4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brew install wvmwas placing only the binary; no bash/zsh/fish completions ever landed because the formula wasn't calling Homebrew's standardgenerate_completions_from_executablehelper.bin.installpreserves that, so the helper's first call to `wvm completions bash` would fail with EACCES otherwise.Same fix as tegmentum/wsvm@eefe4b4.
Test plan
brew tap tegmentum/wvm https://github.com/tegmentum/wvmbrew reinstall wvm, then check: