replace length-0 with empty character when do.call of TDA::*Diag is passed to as_persistence.diagram - fixes #54#58
Open
corybrunson wants to merge 1 commit into
Open
replace length-0 with empty character when do.call of TDA::*Diag is passed to as_persistence.diagram - fixes #54#58corybrunson wants to merge 1 commit into
corybrunson wants to merge 1 commit into
Conversation
…assed to as_persistence.diagram - fixes #54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_persistence.diagram()would fail when the input was obtained throughdo.call(); it now continues without error, but with empty information about the engine.This problem should be more carefully handled in future; this is just a stopgap.