fix(store): apply_pending_auto_save can deadlock - #3572
Merged
Legend-Master merged 2 commits intoSep 16, 2026
Merged
Conversation
Contributor
Package Changes Through 831c052There are 4 changes which include http with patch, http-js with patch, store with patch, store-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
commented
Sep 8, 2026
|
|
||
| fn apply_pending_auto_save(&self) { | ||
| // Cancel and save if auto save is pending | ||
| if let Some(sender) = self.auto_save_debounce_sender.lock().unwrap().take() { |
Contributor
Author
There was a problem hiding this comment.
The lifetime is different here, the lock was not released in the if block
Contributor
Author
|
@amrbashir Could you take a review on this, don't want to drag Fabian-Lars out of vacation, should be just a one line change. |
Legend-Master
requested review from
amrbashir
and removed request for
FabianLars
September 10, 2026 02:42
FabianLars
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3570