feat(fs): allow all reads by default - #3535
Draft
Legend-Master wants to merge 11 commits into
Draft
Legend-Master wants to merge 11 commits into
Legend-Master wants to merge 11 commits into
Conversation
Contributor
Package Changes Through 757ba25There are 4 changes which include http with patch, http-js with patch, fs with patch, fs-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default permission pulls in
read-app-specific-dirs-recursivewhich gives some of the read permissions is weird to me, so this PR changes it to allow all read access to those directories and deprecated theread-app-specific-dirs-recursivepermission.cc @FabianLars @tweidinger for some opinions