Skip to content

feat(skill): route feedback and bug reports to their recipes - #481

Merged
theCodeDrift merged 2 commits into
feedback-channels/recipesfrom
feedback-channels/skill
Oct 9, 2026
Merged

theCodeDrift merged 2 commits into
feedback-channels/recipesfrom
feedback-channels/skill

Conversation

@theCodeDrift

@theCodeDrift theCodeDrift commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Stack (root → tip):

  • Adds triggers and Topics rows to skills/taskless/SKILL.md for sending feedback and reporting a bug.
  • Rewrites the cli-feedback-survey spec's Purpose to cover all three channels.

This stack lands with gh stack merge, which merges every PR to main in one all-or-nothing operation, so no layer reaches main on its own. That matters because the layers only work together. For example, #478 requires kind on the payload while the recipe the invite names still describes a single survey, and #480 lists bug-report in the index before the skill routes to it.

@theCodeDrift

Copy link
Copy Markdown
Member Author

@claude /review

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @theCodeDrift's task in 2m 5s —— View job


Review complete

Review mode: incremental — read 0 prior review thread(s) before reviewing. .prior-review.json contained no reviewThreads, reviews, or comments (other than the trigger comment itself), so this is the first review of this PR.

  • Read .prior-review.json
  • Fetch PR diff and metadata
  • Review changed files (SKILL.md, spec.md, tasks.md) in full context
  • Post findings

Scope

This PR is a small, mechanical slice of the feedback-channels stack (base is feedback-channels/recipes, #480): it adds two Topics rows + two trigger phrases to skills/taskless/SKILL.md, rewrites the cli-feedback-survey spec's ## Purpose, and checks off tasks 4.1–4.3 in tasks.md.

Verification against the rest of the stack

  • agent feedback → general channel, agent bug-report → bug channel: confirmed against TOPIC_INPUT_SCHEMAS in packages/cli/src/prompts/recipes.ts (feedback: generalInputSchema, "bug-report": bugInputSchema) and FEEDBACK_TOPICS in packages/cli/src/commands/agent.ts. The new SKILL.md rows route to the right recipes.
  • The invited survey's recipe (rule-feedback) is intentionally absent from the new Topics rows, matching the comment in agent.ts ("The invited survey's rule-feedback is absent on purpose").
  • Task 4.3 ("add one patch changeset...") is checked off here, but the changeset itself (.changeset/feedback-channels.md) isn't in this PR's diff — it already exists on disk and reads correctly. That's expected per this repo's stacking convention (changeset lives on the bottom PR, docs(openspec): propose feedback-channels #477); not an issue in this PR.
  • tasks.md's diff is just checkbox flips, no scope creep.

Findings

[New] One minor wording nit, posted inline on openspec/specs/cli-feedback-survey/spec.md:5: the rewritten Purpose attributes "need no GitHub account" to bug reports specifically, but the same property applies equally to general feedback per FEEDBACK_TOPICS's descriptions in agent.ts. Not a blocker, just an opportunity for more precise prose.

No correctness, security, or test-adequacy issues found in this diff — it's internally consistent with the merged state of the stack beneath it.

Comment thread openspec/specs/cli-feedback-survey/spec.md Outdated
@theCodeDrift
theCodeDrift force-pushed the feedback-channels/skill branch from a15e430 to 9216f7c Compare October 9, 2026 00:23
@theCodeDrift
theCodeDrift force-pushed the feedback-channels/skill branch from 7f3fe56 to f2c8d98 Compare October 9, 2026 00:32
@theCodeDrift
theCodeDrift merged commit 8543d22 into main Oct 9, 2026
8 checks passed
@theCodeDrift
theCodeDrift deleted the feedback-channels/skill branch October 9, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Open OpenSpec Contains unresolved OpenSpec changes. All openspec changes must eventually reach an archive state.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant