-
Notifications
You must be signed in to change notification settings - Fork 0
feat(cli): Surface routing recipes in the help index #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ef45b0a
feat(cli): Surface routing recipes in the help index
thecodedrift eb100f8
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift 211088d
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift 6d18ca5
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift 8f89d56
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift 569f02a
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift 2c5e215
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift 6ea3252
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift a797a39
test(cli): Assert cli_help for routing topics (telemetry taxonomy)
thecodedrift c4d2556
Merge branch 'feat/local-rule-recipes' into feat/local-rule-help
thecodedrift File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; | ||
|
thecodedrift marked this conversation as resolved.
|
||
|
|
||
| // Spy on the telemetry capture by mocking the telemetry module the help | ||
| // command imports. The factory is invoked lazily at import time, so the | ||
| // closure over `capture` resolves after initialization (same pattern as | ||
| // telemetry.test.ts mocking posthog-node). | ||
| const capture = vi.fn(); | ||
| vi.mock("../src/telemetry", () => ({ | ||
| getTelemetry: vi.fn(() => | ||
| Promise.resolve({ | ||
| capture, | ||
| shutdown: () => Promise.resolve(), | ||
| }) | ||
| ), | ||
| shutdownTelemetry: () => Promise.resolve(), | ||
| })); | ||
|
|
||
| const { createHelpCommand } = await import("../src/commands/help"); | ||
|
|
||
| interface RunnableCommand { | ||
| run: (context: { | ||
| args: { dir: string; anonymous: boolean }; | ||
| rawArgs: string[]; | ||
| }) => Promise<void>; | ||
| } | ||
|
|
||
| describe("help routing topics emit cli_help intent telemetry", () => { | ||
| let logSpy: ReturnType<typeof vi.spyOn>; | ||
|
|
||
| beforeEach(() => { | ||
| capture.mockClear(); | ||
| // Suppress the recipe text the command prints to stdout. | ||
| logSpy = vi.spyOn(console, "log").mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| logSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it.each(["route", "existing", "static", "remote"])( | ||
| "captures cli_help for %s", | ||
| async (topic) => { | ||
| const command = createHelpCommand({}) as unknown as RunnableCommand; | ||
| await command.run({ | ||
| args: { dir: process.cwd(), anonymous: false }, | ||
| rawArgs: ["help", topic], | ||
| }); | ||
|
|
||
| expect(capture).toHaveBeenCalledWith( | ||
| "cli_help", | ||
| expect.objectContaining({ topic }) | ||
| ); | ||
| } | ||
| ); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.