test: disable config checks in config_metrics_test - #549
Open
Godrik0 wants to merge 1 commit into
Open
Conversation
Godrik0
force-pushed
the
gh-12371-checks-off
branch
2 times, most recently
from
July 6, 2026 10:27
2f02b53 to
b804a85
Compare
patapenka-alexey
requested review from
elhimov,
oleg-jukovec and
patapenka-alexey
and removed request for
DifferentialOrange and
georgiy-belyanin
August 14, 2026 13:46
patapenka-alexey
approved these changes
Aug 17, 2026
patapenka-alexey
left a comment
patapenka-alexey
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch!
oleg-jukovec
requested changes
Aug 17, 2026
oleg-jukovec
left a comment
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch, but I’m lacking motivation - why do we need to do this, and why starting from version 3.8.0, not 3.4.0?
Please, discribe it in the PR/commit message.
elhimov
approved these changes
Aug 17, 2026
Set `config.checks` to `'off'` in `default_config` to prevent production checks, such as THP and readahead checks, from affecting `tnt_config_alerts` in tests. The test verifies exact alert counts, so additional host-dependent warnings may cause it to fail in CI. Part of tarantool/tarantool#12371
Godrik0
force-pushed
the
gh-12371-checks-off
branch
from
August 17, 2026 08:34
b804a85 to
af820ea
Compare
Author
|
@oleg-jukovec, This option disables production alerts in tests. Otherwise, tests that expect exact alert counts, such as those using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
config.checksto'off'indefault_configto avoid environment-dependent alerts (THP, readahead) in tests.Part of tarantool/tarantool#12371