Make c-validator module thread-safe - #10
Merged
Merged
Conversation
Reasons to drop it: - Tarantool panics on any malloc failure so there's no need to gracefully handle OOM here. - We don't test the code handling OOM (there's no easy way to test it). - We store a reference to the OOM error in a global variable, which means we must make it thread-local to fix #9. If we dropped the OOM handling code altogether, we wouldn't need to bother. Needed for #9
cv__init is called once when the module is loaded so there's no need to release previously taken Lua references. Moreover, releasing the old references makes it difficult to reproduce #9: the problem is that luaL_ref called right after luaL_unref takes the same slot in the reference table so with the current initialization procedure the bug may only occur if application threads race to load the c-validator module in parallel. Needed for #9
This commit marks all global variables used in the c-validator module thread-local. This should be enough to make it usable in Tarantool application threads. Closes #9
unera
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the c-validator module safe to use in Tarantool application threads.
Closes #9