Repository navigation
Leave the timing selftests ungraded and bound rk mixed by the deadline - #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the last arm64 nightlies tripped over that say nothing about the compiler.
rk testnow reportskselftest:seccomp:seccomp_benchmarkandkselftest:timers:rtcpiewithout grading them, the same way it treats the racy iommu KUnit suites. Both measure time, and under emulation the host decides how long anything takes. On the 6.12.111 A64 night, seccomp_benchmark failed on the rucc kernel because the per-filter cost came out at 469 ns one way and 385 ns the other, and the test itself prints "Try running again with more samples?". rtcpie failed with the rucc userland because it measured 0.0173 s between two interrupts at 64 Hz, where 0.0156 s is expected, and it passed on the same kernel with the GCC userland.The nightly's
rk mixedstep is now bounded by the job deadline, likerk testandrk cross-modulesalready are. On run 39577096697, cross-modules used the time up to the deadline, mixed started about 5h24m in, and the job was cancelled under it, so the step after it never added the mixed record. Now mixed gets the time left before the deadline, and it is skipped with a message when that is under ten minutes.Part of #7.