Repository navigation
Bring libgcc_s.so.1 into a selftests initramfs with libc - #129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 7.2.8 A64 nightly, landlock's tsync_test failed 3 tests on both kernels with "libgcc_s.so.1 must be installed for pthread_cancel to work". glibc loads libgcc_s.so.1 with dlopen the first time a thread is cancelled or exits, to unwind it, so it is in no program's DT_NEEDED and rk never put it in the initramfs.
rk now brings libgcc_s.so.1 along whenever a program needs libc.so.6, from the same library directories as the rest. The host test checks that /bin/sh brings it when the host has one.
Part of #7.