android: device pins/favorites and match iOS long push menu - #856
Open
hiimtmac wants to merge 1 commit into
Open
android: device pins/favorites and match iOS long push menu#856hiimtmac wants to merge 1 commit into
hiimtmac wants to merge 1 commit into
Conversation
hiimtmac
force-pushed
the
tm/support-local-pins
branch
from
September 9, 2026 20:36
c59f7b6 to
fd845fe
Compare
kari-ts
reviewed
Sep 10, 2026
| private val _writing = MutableStateFlow(false) | ||
| val writing: StateFlow<Boolean> = _writing | ||
|
|
||
| private val userFlow = netmapFlow.mapNotNull { it?.User() } |
Collaborator
There was a problem hiding this comment.
pins are scoped per profile login, and iiuc since the active store is being tracked by ipn.ProfileID https://github.com/tailscale/tailscale/blob/023255e8a27ec9f6a21d24e3eda21c052ff72af3/feature/favorites/favorites.go#L68` we should use LoginProfile.ID here?
| val user = currentUser | ||
| revert = null | ||
| _writing.value = true | ||
| client.setFavorites(request) { result -> |
Collaborator
There was a problem hiding this comment.
could multiple setFavorites be in flight at the same time? is it possible that an older request might complete after a newer one and overwrite the newer state?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for device pinning - from device list and from peer detail
Match iOS long push menu - ipv4/ipv6/magic DNS, update icon and reorder
Fixes https://github.com/tailscale/corp/issues/47581
Fixes https://github.com/tailscale/corp/issues/47582
Screen_Recording_20260904_110411.mp4