Skip to content

WorkbookItem.update() always sends an empty <dataAccelerationConfig/> even when never set #1884

Description

@jacalata

WorkbookItem.__init__ defaults data_acceleration_config to a dict with
all-None values:

self.data_acceleration_config = {
    "acceleration_enabled": None,
    "accelerate_now": None,
    "last_updated_at": None,
    "acceleration_status": None,
}

request_factory.py's update_req checks if workbook_item.data_acceleration_config:
to decide whether to emit <dataAccelerationConfig/>. Since the dict itself
is always truthy (non-empty), this is always True — every workbooks.update()
call emits an empty <dataAccelerationConfig/> tag, even when the caller
never touched acceleration settings.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in-progressIssues that are in-progress of being fixed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions