Skip to content

Ignore unmaintained chrono and share one audit job - #45

Merged
jserv merged 2 commits into
mainfrom
security
Nov 18, 2026
Merged

jserv merged 2 commits into
mainfrom
security

Conversation

@jserv

@jserv jserv commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The audit job failed on RUSTSEC-2026-0543: chrono is unmaintained, and rmcp and schemars depend on it unconditionally, so it cannot be dropped from this repository. It is now ignored by ID in .cargo/audit.toml with the reason, and --deny warnings stays on, so every other warning still fails the audit.

ci.yml and security.yml each defined the same cargo-audit job. The definition now lives in security.yml, which also answers workflow_call, and ci.yml calls it. The release job's needs: audit is unchanged. The check is reported as audit / audit now; main has no branch protection or ruleset that requires the old name.

cargo audit --deny warnings passes locally. zizmor is not installed here, so the workflow lint is left to CI.


Summary by cubic

Fixes cargo audit failing on RUSTSEC-2026-0543 by ignoring that advisory in .cargo/audit.toml with the reason, while keeping --deny warnings so every other warning still fails the audit.

Consolidates the duplicated cargo audit job: the definition now lives in security.yml, which answers workflow_call, and ci.yml calls it with the $/.github/workflows/security.yml self-repository syntax that zizmor accepts. The check is reported as audit / audit; no branch protection requires the old name, and the release gate is unchanged.

Written for commit 9e8d776. Summary will update on new commits.

View guided diff Turn on auto-fix

The audit failed on RUSTSEC-2026-0543: chrono is unmaintained, and rmcp
and schemars depend on it unconditionally, so it cannot be dropped here.
Ignore that one ID in .cargo/audit.toml with the reason; every other
warning still fails the audit.

ci.yml and security.yml each defined the same cargo-audit job. Keep the
definition in security.yml, which now also answers workflow_call, and
have ci.yml call it.
cubic-dev-ai[bot]

This comment was marked as resolved.

zizmor's self-repository audit rejects the workspace-relative form of a
reusable workflow call.
@jserv
jserv merged commit e5f89e8 into main Nov 18, 2026
22 of 23 checks passed
@jserv
jserv deleted the security branch November 18, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant