Skip to content

test: wait for containment teardown causally - #290

Merged
Ishaan Gangwani (ishaan1124) merged 2 commits into
mainfrom
codex/fix-macos-ownership-test-race
Aug 14, 2026
Merged

test: wait for containment teardown causally#290
Ishaan Gangwani (ishaan1124) merged 2 commits into
mainfrom
codex/fix-macos-ownership-test-race

Conversation

@ishaan1124

Copy link
Copy Markdown
Member

Summary

  • replace the fixed 100 ms macOS/Linux containment teardown assertion with the existing exact-identity bounded wait
  • prove both the containment owner and escaped descendant are gone before revocation
  • retain the fixed-delay survival assertion on platforms where the child is expected to remain alive

Root cause

owner.exited covers only the SIGKILLed server. The macOS responsibility supervisor observes owner death and drains members asynchronously, so 100 ms is not a lifecycle contract. The identical tree passed on the release PR and missed that window once on merged main.

Verification

  • exact CI trio: 9 pass, 2 skip, 0 fail
  • focused concurrent stress: 4/4 pass
  • root typecheck: 7/7
  • Prettier and diff-check: clean

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openscience Ready Ready Preview Aug 14, 2026 7:33pm

Request Review

@ishaan1124
Ishaan Gangwani (ishaan1124) merged commit 3a82084 into main Aug 14, 2026
17 checks passed
@ishaan1124
Ishaan Gangwani (ishaan1124) deleted the codex/fix-macos-ownership-test-race branch August 14, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant