fix: create channel order only on confirm - #741
Draft
ovitrif wants to merge 1 commit into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
ovitrif
force-pushed
the
fix/738-order-on-confirm
branch
from
September 10, 2026 18:02
487c580 to
7bc4776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #738
Description
This PR moves Blocktank channel-order creation to the final confirmation step of a transfer from savings to spending.
Previously, pressing Continue on Spending Amount or Advanced created an order before the user committed to the transfer. Going back, changing the amount or receiving capacity, and continuing again could create more orders that were left unpaid.
The transfer flow now works as follows:
Fee estimation and order creation use the same backend fee-calculation path. Differences between the fee shown at confirmation and the fee ultimately paid were already possible in the existing flow. This PR preserves that fee behavior and focuses on when the order is created; adding a fee-mismatch guard would be a separate behavior change.
Counterpart: synonymdev/bitkit-android#1247
Design
N/A — no UI changes.
Preview
ios-transfer-preview.mp4
QA Notes
Manual Tests
Automated Checks
BitkitTests/TransferViewModelTests.swift:BitkitTests/TransferViewModelHwTests.swift.@transfer_1then failed opening Settings behind the Background Payments sheet.