fix: prevent false on-chain send success - #727
Draft
ovitrif wants to merge 8 commits into
Draft
Conversation
Validated against the exact local LDK Node 0.7.0-rc.67 artifact from ldk-node#113. Publication requires non-author approval of ldk-node#113 and an authorized rc.67 release.
ovitrif
force-pushed
the
codex/717-onchain-send-result
branch
from
September 8, 2026 12:56
1ddd21e to
6454ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #717
Description
Dependency
synonymdev/ldk-node#113at source head7d359aee31282c5f9a1a8fe65b24b523cb5c101b, which adds the durableBroadcastOutcomelookup and acknowledgement contract, retains recovery state before dispatch, and preserves recovery across cleanup persistence failures.6b60fe0df32362d6c6604393071110e94a2058b8; the earlier local archive from that predecessor has checksum549f7a962f7b4262ef77b7e65abd6fe588be87801bee35da6295571c141f183band does not include the subsequent internal recovery fixes.Preview
Earlier accepted and deterministic rejection captures:
717-current-artifact-accepted.mp4
717-current-artifact-rejected.mp4
Current-head pending/outcome media was not recorded.
QA Notes
Manual Tests
Automated Checks
a67f441bincludes livemasterat1cf0a425and the authoritative-outcome integration. It was not built, parsed, formatted, or test-run; published rc.66 lacks the required APIs.6a6b0c06passed source parsing, diff whitespace inspection, focused SwiftFormat inspection, and the CI translation check; those results do not validate the current outcome integration.6454ee3passed 7/7OnchainSendResultTestsagainst an unpublished source-equivalent artifact; that result does not validate the current reconciliation changes.158bdd1c2b81413b451f16b3331d261086daa73d03869e7a72099e5e83c6bin block00941d326f26ccedfec7305849c0c176442a9e3c1509dc2c0b9a934768d5fc5b.-26 non-finalwithout reaching success.