Skip to content

test: wait for spending confirm after advanced continue #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotr-iohk merged 5 commits into from
Sep 9, 2026
Merged

test: wait for spending confirm after advanced continue #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2d72e8
test: wait for spending confirm after advanced continue
piotr-iohk Sep 4, 2026
218f883
Merge branch 'main' into fix/spending-transfer-affordability
piotr-iohk Sep 5, 2026
f16f313
test: stabilize @transfer_1 after spending confirm
piotr-iohk Sep 7, 2026
e393c89
test: trasnfer_max
piotr-iohk Sep 7, 2026
0b13a17
Merge branch 'main' into fix/spending-transfer-affordability
piotr-iohk Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/helpers/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,8 @@ export async function expectTextWithin(
}

return strategy === 'exact'
? `.//*[self::XCUIElementTypeStaticText or self::XCUIElementTypeTextView or self::XCUIElementTypeTextField][@label='${text}' or @value='${text}']`
: `.//*[self::XCUIElementTypeStaticText or self::XCUIElementTypeTextView or self::XCUIElementTypeTextField][contains(@label,'${text}') or contains(@value,'${text}')]`;
? `.//*[self::XCUIElementTypeStaticText or self::XCUIElementTypeTextView or self::XCUIElementTypeTextField or self::XCUIElementTypeButton][@label='${text}' or @value='${text}']`
: `.//*[self::XCUIElementTypeStaticText or self::XCUIElementTypeTextView or self::XCUIElementTypeTextField or self::XCUIElementTypeButton][contains(@label,'${text}') or contains(@value,'${text}')]`;
})();

if (!visible) {
Expand Down
85 changes: 72 additions & 13 deletions test/specs/transfer.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
dismissBackgroundPaymentsTimedSheet,
expectNoTextWithin,
enterAmount,
expectSavingsBalance,
} from '../helpers/actions';
import {
checkChannelStatus,
Expand All @@ -38,6 +39,19 @@ import { reinstallApp } from '../helpers/setup';
import { ciIt } from '../helpers/suite';
import { openSettings } from '../helpers/navigation';

/** One Back should leave Confirm. iOS sometimes needs a second Back; Android does not. */
async function backToSpendingAmount() {
await tap('NavigationBack');
await sleep(500);
if (driver.isIOS && (await elementById('SpendingConfirmMore').isDisplayed().catch(() => false))) {
console.info('→ Still on spending confirm, tapping Back again...');
await tap('NavigationBack');
await sleep(500);
}
await elementById('SpendingAmountAvailable').waitForDisplayed();
await sleep(1000);
}

describe('@transfer - Transfer', () => {
let electrum: { waitForSync: () => any; stop: () => void };

Expand All @@ -62,6 +76,7 @@ describe('@transfer - Transfer', () => {
// - can change amount
// Advanced
// - can change amount
// Can fund a channel at the settled Max (happy path; fee-direction math is unit-tested)
// Can open a channel to external node
// - open channel to LND
// - send payment
Expand Down Expand Up @@ -89,8 +104,10 @@ describe('@transfer - Transfer', () => {
// can continue with default client balance (0)
await elementById('SpendingAmountContinue').waitForEnabled();
await tap('SpendingAmountContinue');
await sleep(700);
await elementById('SpendingConfirmAdvanced').waitForDisplayed();
await sleep(500);
await tap('SpendingConfirmAdvanced');
await sleep(500);
await tap('SpendingAdvancedMin');
await expectText('100 000', { strategy: 'contains' });
await tap('SpendingAdvancedDefault');
Expand All @@ -102,9 +119,9 @@ describe('@transfer - Transfer', () => {
await sleep(1000);
await tap('SpendingAdvancedNumberField'); // change back to sats
await tap('SpendingAdvancedContinue');
await elementById('SpendingConfirmDefault').waitForDisplayed();
await sleep(500);
await tap('NavigationBack');
await sleep(1000);
await backToSpendingAmount();

// can continue with max client balance
await tap('SpendingAmountMax').catch(async () => {
Expand All @@ -117,25 +134,30 @@ describe('@transfer - Transfer', () => {
await sleep(500);
await tap('SpendingAmountContinue');
await elementById('SpendingConfirmAdvanced').waitForDisplayed();
await tap('NavigationBack');
await sleep(1000);
await backToSpendingAmount();

// can continue with 25% client balance
await elementById('SpendingAmountQuarter').waitForEnabled();
await tap('SpendingAmountQuarter');
await elementById('SpendingAmountContinue').waitForEnabled();
await sleep(500);
await tap('SpendingAmountContinue');
await elementById('SpendingConfirmAdvanced').waitForDisplayed();
await tap('NavigationBack');
await backToSpendingAmount();
await tap('NavigationBack');
await sleep(1000);
await tap('SpendingIntro-button');
await sleep(2000);
await elementById('SpendingAmountAvailable').waitForDisplayed();
await elementById('N2').waitForEnabled();
await sleep(500);

// can change client balance
await enterAmount(200000);
await sleep(500);
await expectText('200 000', { strategy: 'contains' });
await tap('SpendingAmountContinue');
await elementById('SpendingConfirmMore').waitForDisplayed();
await sleep(500);
await expectText('200 000', { strategy: 'contains' });
await tap('SpendingConfirmMore');
await expectText('200 000');
Expand Down Expand Up @@ -166,10 +188,12 @@ describe('@transfer - Transfer', () => {
await elementById('SpendingAmountContinue').waitForEnabled();
await sleep(2000);
await enterAmount(100000);
await sleep(500);
await tap('SpendingAmountContinue');
await expectText('100 000', { strategy: 'contains' });
await sleep(500);
await tap('SpendingConfirmAdvanced');
await elementById('SpendingAdvancedMin').waitForDisplayed();
await sleep(500);

// Receiving Capacity
Expand All @@ -179,33 +203,33 @@ describe('@transfer - Transfer', () => {
await expectText('2 500');
await expectText('—', { visible: false });
await tap('SpendingAdvancedContinue');
await sleep(500);
await elementById('SpendingConfirmDefault').waitForDisplayed();
await tap('SpendingConfirmDefault');
await sleep(500);
await tap('SpendingConfirmAdvanced');
await sleep(500);
await elementById('SpendingAdvancedDefault').waitForDisplayed();

// can continue with default amount
await tap('SpendingAdvancedDefault');
await sleep(500);
await expectText('—', { visible: false });
await tap('SpendingAdvancedContinue');
await sleep(500);
await elementById('SpendingConfirmDefault').waitForDisplayed();
await tap('SpendingConfirmDefault');
await sleep(500);
await tap('SpendingConfirmAdvanced');
await sleep(500);
await elementById('SpendingAdvancedMax').waitForDisplayed();

// can continue with max amount
await tap('SpendingAdvancedMax');
await sleep(500);
await expectText('—', { visible: false });
await tap('SpendingAdvancedContinue');
await sleep(500);
await elementById('SpendingConfirmDefault').waitForDisplayed();
await tap('SpendingConfirmDefault');
await sleep(500);
await tap('SpendingConfirmAdvanced');
await sleep(2000);
await elementById('SpendingAdvancedNumberField').waitForDisplayed();

// can set custom amount
await enterAmount(150000);
Expand Down Expand Up @@ -274,6 +298,41 @@ describe('@transfer - Transfer', () => {
}
);

ciIt('@transfer_max - Can fund a Blocktank channel at the settled maximum', async () => {
await receiveOnchainFunds({ sats: 100_000 });

await tap('ActivitySavings');
await elementById('TransferToSpending').waitForDisplayed();
await tap('TransferToSpending');
if (await elementById('SpendingIntro-button').isDisplayed().catch(() => false)) {
await tap('SpendingIntro-button');
}

await elementById('SpendingAmountAvailable').waitForDisplayed();
await elementById('SpendingAmountContinue').waitForEnabled();
await elementById('SpendingAmountMax').waitForEnabled();
await sleep(500);

await tap('SpendingAmountMax');
await elementById('SpendingAmountContinue').waitForEnabled();
await tap('SpendingAmountContinue');
await elementById('SpendingConfirmMore').waitForDisplayed();
await sleep(500);

await dragOnElement('GRAB', 'right', 0.95);
await elementById('LightningSettingUp').waitForDisplayed();
await tap('TransferSuccess-button');

await expectSavingsBalance(0);

// Short-0 is already the receive row from `receiveOnchainFunds`. Wait until that
// row becomes Short-1 so Short-0 is the transfer, same as @onchain / @transfer_2.
await elementById('ActivityShort-0').waitForDisplayed();
await elementById('ActivityShort-1').waitForDisplayed();
await expectTextWithin('ActivityShort-0', 'Transfer');
await expectTextWithin('ActivityShort-1', 'Received');
});

ciIt('@transfer_2 - Can open a channel to external node', async () => {
const rpc = getBitcoinRpc();
await receiveOnchainFunds({ sats: 100_000 });
Expand Down