fix: use fast fee for savings transfer#1091
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThis PR updates savings-to-spending transfers to use fast on-chain fees. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/viewmodels/TransferViewModel.kt | Uses fast-fee reservation, prepared coin selection, and dust-aware wallet draining for savings transfers. |
| app/src/main/java/to/bitkit/repositories/LightningRepo.kt | Adds a repository wrapper for algorithm-specific UTXO selection. |
| app/src/main/java/to/bitkit/ui/screens/transfer/SpendingConfirmScreen.kt | Displays the prepared mining fee and blocks confirmation until it is ready. |
| app/src/test/java/to/bitkit/viewmodels/TransferViewModelTest.kt | Adds coverage for fast-fee reservation, fallback sizing, dust draining, and fixed sends. |
Reviews (3): Last reviewed commit: "Merge branch 'master' into fix/1034-savi..." | Re-trigger Greptile
piotr-iohk
marked this pull request as draft
July 17, 2026 10:34
Co-authored-by: Cursor <cursoragent@cursor.com>
jvsena42
requested changes
Jul 17, 2026
piotr-iohk
marked this pull request as draft
July 20, 2026 12:40
piotr-iohk
marked this pull request as ready for review
July 20, 2026 14:13
jvsena42
requested changes
Jul 20, 2026
jvsena42
self-requested a review
July 21, 2026 10:45
jvsena42
requested changes
Jul 21, 2026
jvsena42
left a comment
Member
There was a problem hiding this comment.
Code is good, just need some style changes
jvsena42
enabled auto-merge
July 21, 2026 12:07
jvsena42
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1034
This PR makes savings → spending channel funding use a faster on-chain fee rate, matching the “~10 minutes” copy and iOS behavior.
Description
multi_address_2).viewModelScopeso broadcast + paid-order caching are not cancelled by Compose scope teardown.Preview
N/A
QA Notes
Manual Tests
regression:Transfer → Spending with a partial amount well below balance: still funds with a normal (non-drain) send when change is above dust.Automated Checks
TransferViewModelTest.kt.just test file TransferViewModelTest.multi_address_2should pass once this lands on the resolved e2e branch.