-
Notifications
You must be signed in to change notification settings - Fork 64
[DS 2.0] Keep node title and subtitle on one line with ellipsis and tooltip #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflowbuilder/sdk': patch | ||
| --- | ||
|
|
||
| Decision branch rows and AI tool rows show the full label in a tooltip when the text is truncated. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflowbuilder/ui': patch | ||
| --- | ||
|
|
||
| `NodeDescription` keeps both the title and the subtitle on one line: long text is truncated with an ellipsis and exposed in full through the element's native tooltip, and the text no longer widens nodes whose body sizes to its content (for example the Decision node). Nodes keep the fixed design width and grow in height only. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import { ConnectableItem } from './connectable-item'; | ||
|
|
||
| vi.mock('@xyflow/react', () => ({ | ||
| Handle: ({ id }: { id: string }) => <span data-testid="handle" data-handle-id={id} />, | ||
| Position: { Right: 'right', Bottom: 'bottom' }, | ||
| })); | ||
|
|
||
| vi.mock('../../../../../store/store', () => ({ | ||
| useStore: (selector: (state: { layoutDirection: 'RIGHT' | 'DOWN' }) => unknown) => | ||
| selector({ layoutDirection: 'RIGHT' }), | ||
| })); | ||
|
|
||
| describe('ConnectableItem', () => { | ||
| it('exposes the full label as a tooltip so a clipped row stays readable', () => { | ||
| const label = 'Small and medium business with an unusually long branch label'; | ||
|
|
||
| render(<ConnectableItem handleId="source:inner:b2" label={label} />); | ||
|
|
||
| expect(screen.getByText(label).getAttribute('title')).toBe(label); | ||
| expect(screen.getByTestId('handle').dataset.handleId).toBe('source:inner:b2'); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,21 @@ | |
| align-items: flex-start; | ||
| overflow: hidden; | ||
| width: 100%; | ||
| min-width: 0; | ||
| contain: inline-size; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| .title { | ||
| color: var(--wb-public-node-title-color); | ||
| .title, | ||
| .subtitle { | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; | ||
| white-space: nowrap; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .title { | ||
| color: var(--wb-public-node-title-color); | ||
| } | ||
|
|
||
| .subtitle { | ||
| color: var(--wb-public-node-title-subtitle); | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { act } from 'react'; | ||
| import { type Root, createRoot } from 'react-dom/client'; | ||
|
|
||
| import { NodeDescription } from './node-description'; | ||
|
|
||
| (globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true; | ||
|
|
||
| let container: HTMLDivElement; | ||
| let root: Root; | ||
|
|
||
| beforeEach(() => { | ||
| container = document.createElement('div'); | ||
| document.body.append(container); | ||
| root = createRoot(container); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| act(() => root.unmount()); | ||
| container.remove(); | ||
| }); | ||
|
|
||
| describe('NodeDescription', () => { | ||
| it('exposes the full label and description as native tooltips for truncated text', () => { | ||
| act(() => | ||
| root.render(<NodeDescription label="Route by Type" description="Sends the ticket to the right responder." />), | ||
| ); | ||
|
|
||
| const [title, subtitle] = container.querySelectorAll('span'); | ||
| expect(title.getAttribute('title')).toBe('Route by Type'); | ||
| expect(subtitle.getAttribute('title')).toBe('Sends the ticket to the right responder.'); | ||
| }); | ||
|
|
||
| it('renders no tooltip attribute when there is no description', () => { | ||
| act(() => root.render(<NodeDescription label="Start" />)); | ||
|
|
||
| const [, subtitle] = container.querySelectorAll('span'); | ||
| expect(subtitle.hasAttribute('title')).toBe(false); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,8 +11,12 @@ export type NodeDescriptionProps = { | |
| export function NodeDescription({ label, description, className }: NodeDescriptionProps) { | ||
| return ( | ||
| <div className={clsx(styles['container'], className)}> | ||
| <span className={clsx('wb-text-title-s-emphasized', styles['title'])}>{label}</span> | ||
| <span className={clsx('wb-text-node-s', styles['subtitle'])}>{description}</span> | ||
| <span className={clsx('wb-text-title-s-emphasized', styles['title'])} title={label}> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The description says the DS |
||
| {label} | ||
| </span> | ||
| <span className={clsx('wb-text-node-s', styles['subtitle'])} title={description}> | ||
| {description} | ||
| </span> | ||
| </div> | ||
| ); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit on wording, since this becomes the CHANGELOG: the
titleis set always, not only when clipped. Suggest: "Decision branch rows and AI tool rows expose the full label as a native tooltip (title), so a clipped row stays readable."