Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/connectable-item-tooltip.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@workflowbuilder/sdk': patch
---

Decision branch rows and AI tool rows show the full label in a tooltip when the text is truncated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on wording, since this becomes the CHANGELOG: the title is set always, not only when clipped. Suggest: "Decision branch rows and AI tool rows expose the full label as a native tooltip (title), so a clipped row stays readable."

5 changes: 5 additions & 0 deletions .changeset/node-text-ellipsis.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@workflowbuilder/ui': patch
---

`NodeDescription` keeps both the title and the subtitle on one line: long text is truncated with an ellipsis and exposed in full through the element's native tooltip, and the text no longer widens nodes whose body sizes to its content (for example the Decision node). Nodes keep the fixed design width and grow in height only.
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ function NodeHeader({ icon, label, description }) {
}
```

## Truncation

Both lines are single-line. Text that does not fit the node width is cut with an ellipsis and the
full text is available through the element's native tooltip (`title`). The block never widens its
node: a node keeps the design width and grows in height only through its body content.

## Props

<PropsTable slug="node-description" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { ConnectableItem } from './connectable-item';

vi.mock('@xyflow/react', () => ({
Handle: ({ id }: { id: string }) => <span data-testid="handle" data-handle-id={id} />,
Position: { Right: 'right', Bottom: 'bottom' },
}));

vi.mock('../../../../../store/store', () => ({
useStore: (selector: (state: { layoutDirection: 'RIGHT' | 'DOWN' }) => unknown) =>
selector({ layoutDirection: 'RIGHT' }),
}));

describe('ConnectableItem', () => {
it('exposes the full label as a tooltip so a clipped row stays readable', () => {
const label = 'Small and medium business with an unusually long branch label';

render(<ConnectableItem handleId="source:inner:b2" label={label} />);

expect(screen.getByText(label).getAttribute('title')).toBe(label);
expect(screen.getByTestId('handle').dataset.handleId).toBe('source:inner:b2');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ export function ConnectableItem({ handleId, label, canHaveBottomHandle = true }:
[styles['connectable-item--right']]: layoutDirection === 'RIGHT',
})}
>
<div className={styles['label']}>{label}</div>
<div className={styles['label']} title={label}>
{label}
</div>
<div className={clsx(styles['handle-container'], { [styles['vertical']]: isVertical })}>
<Handle id={handleId} position={position} type="source" />
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,21 @@
align-items: flex-start;
overflow: hidden;
width: 100%;
min-width: 0;
contain: inline-size;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contain: inline-size zeroes the block's intrinsic contribution, so NodeDescription now only renders text when an ancestor has a definite inline size. Inside NodePanel.Header it does, via the 241px .container, and every render site in the repo is safe. But it is a public ui export: a consumer dropping it into an inline-flex or fit-content wrapper would see it collapse to 0 with no error. Could we state that constraint in the Truncation section and in the ui changeset?


.title {
color: var(--wb-public-node-title-color);
.title,
.subtitle {
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
width: 100%;
}

.title {
color: var(--wb-public-node-title-color);
}

.subtitle {
color: var(--wb-public-node-title-subtitle);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { act } from 'react';
import { type Root, createRoot } from 'react-dom/client';

import { NodeDescription } from './node-description';

(globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;

let container: HTMLDivElement;
let root: Root;

beforeEach(() => {
container = document.createElement('div');
document.body.append(container);
root = createRoot(container);
});

afterEach(() => {
act(() => root.unmount());
container.remove();
});

describe('NodeDescription', () => {
it('exposes the full label and description as native tooltips for truncated text', () => {
act(() =>
root.render(<NodeDescription label="Route by Type" description="Sends the ticket to the right responder." />),
);

const [title, subtitle] = container.querySelectorAll('span');
expect(title.getAttribute('title')).toBe('Route by Type');
expect(subtitle.getAttribute('title')).toBe('Sends the ticket to the right responder.');
});

it('renders no tooltip attribute when there is no description', () => {
act(() => root.render(<NodeDescription label="Start" />));

const [, subtitle] = container.querySelectorAll('span');
expect(subtitle.hasAttribute('title')).toBe(false);
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,12 @@ export type NodeDescriptionProps = {
export function NodeDescription({ label, description, className }: NodeDescriptionProps) {
return (
<div className={clsx(styles['container'], className)}>
<span className={clsx('wb-text-title-s-emphasized', styles['title'])}>{label}</span>
<span className={clsx('wb-text-node-s', styles['subtitle'])}>{description}</span>
<span className={clsx('wb-text-title-s-emphasized', styles['title'])} title={label}>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description says the DS Tooltip will replace title later. Could the tsx carry a one-liner with a follow-up slug, e.g. // Native title until the DS Tooltip takes over; keyboard users get no tooltip today (follow-up: node-text-ds-tooltip)? That is the CLAUDE.md convention for future work and keeps it grep-able for the PRs stacked on this one.

{label}
</span>
<span className={clsx('wb-text-node-s', styles['subtitle'])} title={description}>
{description}
</span>
</div>
);
}
Loading