Add @fluentui/react-charts ResponsiveContainer#30
Open
rbertels wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Andrew,
After dabbling with the charts I've found that there is a
ResponsiveContainerinside the official package.It is built to wrap a chart element and handle resize events.
This pull requests adds this container and its props.
Attached is a GIF of the testbed showing a chart that is wrapped (above) vs a chart that is not (below).
As you can see the unwrapped chart needs a 'hover' event to trigger a redraw.
Happy to hear your thoughts!
PS. I've been running the 4.0.0-prerelease-003 for a while now I think it may be ready for the real world :)