Fix: Identity equality for non Equatable clases.#787
Merged
Conversation
ktoso
reviewed
Jun 15, 2026
| @JavaMethod | ||
| public static func equals(environment: UnsafeMutablePointer<JNIEnv?>!, lhsPointer: Int64, lhsTypePointer: Int64, rhsPointer: Int64, rhsTypePointer: Int64) -> Bool { | ||
| // Fallback for non-equatable types (such as classes) | ||
| let isEquatableByIdentity = lhsPointer == rhsPointer && lhsTypePointer == rhsTypePointer |
Collaborator
There was a problem hiding this comment.
A test would be nice to add for these
Collaborator
There was a problem hiding this comment.
Also naming nitpick, this is "is equal" and not "is equatable" we're not checking if the types are equatABLE but if they are :)
Collaborator
|
I did the tiny followup and will merge, thank you! |
Collaborator
|
Nightly Swift seems broken for unrelated reasons rdar://179674933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use identity for
equalsmethods for types that do not implementEquatable, for example classes:Swift:
Java: