Limit bitset payloads in quantifier instruction - #873
Open
natecook1000 wants to merge 2 commits into
Open
Conversation
Instructions always store an 8-bit opcode in their high byte, with the 56 low bits for their payload. The current method of storing two values in the payload limits each value to 16 bits, which is less than what is required for some (unreasonable but) allowed patterns. This change increases the limit of each value to 24 bits.
Quantifier instructions can directly include a bitset register address, but the register address space can overflow the allotted 16 bits for that payload in the quantifier instruction. This change caps the register address size when storing a bitset in a register, failing out of the optimized quantifier instruction when the value would overflow. rdar://185730811
Member
Author
|
@swift-ci Please test Linux platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quantifier instructions can directly include a bitset register address, but the register address space can overflow the allotted 16 bits for that payload in the quantifier instruction. This change caps the register address size when storing a bitset in a register, failing out of the optimized quantifier instruction when the value would overflow.
rdar://185730811